fix(cef): select the soft-navigation crash fix in build 3586 - #1
Open
zackarychapple wants to merge 2 commits into
Open
fix(cef): select the soft-navigation crash fix in build 3586#1zackarychapple wants to merge 2 commits into
zackarychapple wants to merge 2 commits into
Conversation
Select CEF 151.1.0-HEAD.3586, which carries the upstream null-safe tab lookup in ReadAnythingSoftNavigationObserver. Keep generated version metadata aligned across supported platforms; the C API and Chromium version are unchanged.
zackarychapple
changed the base branch from
dev
to
codex/151-prebuilt-windows-wrapper
September 6, 2026 11:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CEF 151 Alloy embedders can segfault on SPA soft navigation because ReadAnythingSoftNavigationObserver calls TabInterface::GetFromContents for WebContents that is not a Chrome tab. Select CrabNebula framework 151.1.0-HEAD.3586, which carries the upstream MaybeGetFromContents fix, and align the generated version constants.
The framework source is the direct child of the previous build: upstream fix, CEF issue. Chromium remains 151.0.7922.0.
Testing
cargo fmt --all -- --check— passed.python3 sys/tests/prebuilt-wrapper.py— passed (one integration test covering the Windows prebuilt-wrapper handoff, override changes, missing artifacts, and native-build fallback).Manual Testing
No Linux or Windows runtime result is claimed.
Review notes
Based on
codex/151-prebuilt-windows-wrapperatb7d425b8504cd3e7e10d193f8991aff415d10959to preserve the existing Windows wrapper handoff. The change against that base remains five version-metadata lines. The complete route replay above used framework3586 before the Windows-wrapper base integration. A refreshed signed macOS arm64 embedder now also passes the original workspace switch with the combined head6310198885d6b84bf0e0a57124f2e65bd5d0e30e; the same native process remained alive. The complete route sequence was not repeated on that combined head.